refactor: store the last 3 navigations in PageCollector #411
+97
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Oct 17, 2025
Collaborator
OrKoN
left a comment
OrKoN
left a comment
There was a problem hiding this comment.
LGTM but let's add a e2e test verifying that we can indeed format console and network messages from previous navigations
OrKoN
reviewed
Oct 17, 2025
Collaborator
Author
|
Currently we cover that we can get the data properly formatted for the current navigation with an e2e test, so that should be sufficient to show we did not regress. |
Lightning00Blade
force-pushed
the
refactor-save-3-navigations
branch
from
c679a6c to
2d3beca
Compare
Lightning00Blade
force-pushed
the
refactor-save-3-navigations
branch
from
2d3beca to
5d24ea4
Compare
OrKoN
pushed a commit
that referenced
this pull request
Oct 22, 2025
🤖 I have created a release *beep* *boop* --- ## [0.9.0](chrome-devtools-mcp-v0.8.1...chrome-devtools-mcp-v0.9.0) (2025-10-22) ### 🎉 Features * add claude marketplace and plugin json ([#396](#396)) ([0498611](0498611)) * add filters and pagination to the console messages tool ([#387](#387)) ([15d942c](15d942c)) * add WebSocket endpoint and custom headers support ([#404](#404)) ([41d6a10](41d6a10)) * allow configuring tool categories ([#454](#454)) ([0fe2b8a](0fe2b8a)) * expose previous navigations to the MCP ([#419](#419)) ([165cf9c](165cf9c)) * support previous navigation for Console messages ([#452](#452)) ([6f24362](6f24362)) * support stable id for network requests ([#375](#375)) ([f4d7b49](f4d7b49)) * support verbose snapshots ([#388](#388)) ([d47aaa9](d47aaa9)) * tool to get a verbose single console message ([#435](#435)) ([9205593](9205593)) * use stable id for network request querying ([#382](#382)) ([579819b](579819b)) ### 🛠️ Fixes * allow evaluating in Frames ([#443](#443)) ([053f1f8](053f1f8)) * better wording for evaluate_script ([#392](#392)) ([2313fda](2313fda)) * indicate when request and response bodies are not available ([#446](#446)) ([7d47d6b](7d47d6b)) * pageerror for non-error types ([#442](#442)) ([b6b42ec](b6b42ec)) * retrieve data correctly with fewer than 3 navigations ([#451](#451)) ([4c65f59](4c65f59)) ### 📄 Documentation * add instructions for Qoder ([#386](#386)) ([d8df784](d8df784)) * add VM-to-host remote debugging workaround ([#399](#399)) ([9f9dab0](9f9dab0)) * Update Copilot CLI instructions ([#423](#423)) ([c7733a8](c7733a8)) ### ♻️ Chores * bundle all dependencies together ([#450](#450)) ([914b980](914b980)) * bundle modelcontextprotocol-sdk ([#409](#409)) ([6c8432b](6c8432b)) * bundle puppeteer-core ([#417](#417)) ([b443033](b443033)) * bundle zod together with modelcontextprotocol/sdk ([#414](#414)) ([800e7e8](800e7e8)) * cleanup data fetching ([#441](#441)) ([5c871c3](5c871c3)) * dispose listeners on page destroyed ([#318](#318)) ([76d5e94](76d5e94)) * extract common paginate type ([#415](#415)) ([29fd602](29fd602)) * store the last 3 navigations in PageCollector ([#411](#411)) ([b873822](b873822)) * use different format for reqid ([#380](#380)) ([78bf66a](78bf66a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the code to support #88
We keep each navigation in a separate array, that we can then expose to the user.